rust-bitcoin / rust-bitcoin / 7872599806

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2463: Add conditional check for debug_assertions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/1d13020129669a4435941bef0eb680ba718a1b14">1d1302012 test: Add conditional check for debug_assertions (yancy)

Pull request description:

  Currently running `cargo test --release` blows up because of the tests that panic.  This PR adds a conditional check `debug_assertions` which causes those tests to not be run in release mode.  Besides fixing `cargo test --release` this PR sets the stage for a larger PR to test arithmetic tests that are `unchecked` (will overflow in release mode instead of panic) started here https://github.com/rust-bitcoin/rust-bitcoin/pull/2436.  Also I think we ought to add `cargo test --release` to CI.

ACKs for top commit:
  Kixunil:
    ACK 1d13020129669a4435941bef0eb680ba718a1b14
  apoelstra:
    ACK 1d13020129669a4435941bef0eb680ba718a1b14

Tree-SHA512: 8964af57d6a28572085eac2a4b2b61725fc

19386 of 23060 relevant lines covered (84.07%)

16800.05 hits per line