celerity / celerity-runtime / 7848944582

94%

master: 95%

Build Type

Pull #246

github

Committed by fknorr

Commit Message

Explicitly manage buffer / host object lifetimes in graph generation

task_manager and distributed_graph_generator already maintain state for each
buffer and host object, but keep it around indefinitely even after the
buffer or host object in question is destroyed. Also, neither have
access to buffer debug names and thus can't include that information in
error reports (such as uninitialized-read detection).

This commit adds explicit methods for tracking the creation and
destruction of objects to task_manager, distributed_graph_generator,
scheduler (and now by necessity, runtime, which receives these requests
directly instead of via the buffer_lifetime_callback).

This also removes the recorder -> buffer_manager dependency by
replicating the buffer name (like all other metadata) in both graph
generators. This foreshadows the eventual removal of buffer_manager with
the merge of instruction graph scheduling.

Pull Request Pull Request #246: Explicitly manage buffer / host object lifetimes in graph generation

Run Details

2237 of 2509 branches covered (0.0%)

Branch coverage included in aggregate %.

192 of 193 new or added lines in 15 files covered. (99.48%)

6 existing lines in 3 files now uncovered.

5066 of 5258 relevant lines covered (96.35%)

220506.71 hits per line