• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zalando-incubator / cluster-lifecycle-manager / 7847141936
23%

Build:
DEFAULT BRANCH: master
Ran 09 Feb 2024 05:02PM UTC
Jobs 1
Files 41
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Feb 2024 04:57PM UTC coverage: 52.585% (+0.4%) from 52.229%
7847141936

push

github

web-flow
add template functions for dynamic resource scaling (#743)

* add divideInstanceResourcesInRatio template function

Signed-off-by: Noor Malik <nmalik@zalando-70804.corp.ad.zalando.net>

* make divideInstanceResourcesInRatio return 2 values

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* add scaleQuantity function and add testcases for it

Also refactors divideInstanceResourcesInRatio into
two composable functions instanceTypeCPU and
instanceTypeMemory.

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* use in-memory instance data

This refactors the code to pass on the instance data fetched in the
Provision function of CLM. The renderTemplate has been extended to
include the InstanceTypes type which is then passed to other functions
like renderSingleTemplate.

prepareProvision function has been extended to return the instanceTypes
data which is used in Provision function. This makes sure that we only
fetch the data from AWS API once and use it everywhere.

Additionally, NodePoolTemplateRenderer has been extended to include
instanceTypes information centrally and that has been removed from the
AWSNodePoolProvisioner.

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* parse k8s quantities as string and update unit tests

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* add unit tests for instanceType* functions

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* fix scaleQuantity function and tidy up unit tests

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* add scaling test cases for fraction Gi memory and add suffix to functions

Signed-off-by: Noor Malik <noor.malik@zalando.de>

* fix nit

Signed-off-by: Noor Malik <noor.malik@zalando.de>

---------

Signed-off-by: Noor Malik <nmalik@zalando-70804.corp.ad.zalando.net>
Signed-off-by: Noor Malik <noor.malik@zalando.de>
Co-authored-by: Noor Malik <nmalik@zalando-70804.corp.ad.zalando.net>

2950 of 5610 relevant lines covered (52.58%)

15.3 hits per line

Jobs
ID Job ID Ran Files Coverage
1 7847141936.1 09 Feb 2024 05:02PM UTC 41
52.58
GitHub Action Run
Source Files on build 7847141936
  • Tree
  • List 41
  • Changed 5
  • Source Changed 0
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • a36b673d on github
  • Prev Build on master (#7846966322)
  • Next Build on master (#7962285232)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc