zooniverse / front-end-monorepo / 7833207531

77%

push

github

refactor: fix missing effect dependencies (#5875)

* refactor: fix missing effect dependencies
Declare `isBrowser` and `localStorage` in the global scope, so that they aren't declared on each app render. Add an `initialTheme` variable to store the initial theme state when a page loads.

* Refactor initialTheme to allow for dark theme

* Clean up redundant component state

* Set initialTheme to 'light' during SSR

* Add an extra setState call in the browser
Grommet doesn't pick up the theme correctly without an extra `setThemeMode` call inside a `useEffectHook`, when the page mounts.

* Simplify the effect hook

* Enable MST static rendering in Node

* Move useState and useEffect into usePreferredTheme

---------

Co-authored-by: Delilah C <23665803+goplayoutside3@users.noreply.github.com>

10435 of 14545 branches covered (0.0%)

Branch coverage included in aggregate %.

15754 of 17718 relevant lines covered (88.92%)

433.96 hits per line