7818206641
81%

Ran 07 Feb 2024 04:48PM UTC

Jobs 1

Files 22

Run time 2s

Badge

Embed ▾

Committed 07 Feb 2024 04:44PM UTC coverage: 91.006% (+0.3%) from 90.755%

Build # 7818206641

Build Type

push

github

Committed by

web-flow

Commit Message

fix: reject identity keys and commitments in signatures (#217)

Signature verification currently allows identity elements:
- `SchnorrSignature` allows an identity public key
- `CommitmentSignature` allows an identity commitment
- `CommitmentAndPublicKeySignature` allows both

This doesn't strictly break soundness, but does remove message binding.
While it shouldn't be problematic for unforgeability, it's a case that
shouldn't arise from an honest signer and is easy to check for.

This PR fails signature verification if such an identity element is
provided, and adds tests for each case. It does _not_ return an error if
the corresponding identity elements are provided by the signer, since
this precludes useful partial signature operations.

Run Details

3592 of 3947 relevant lines covered (91.01%)

57.19 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7818206641.1	07 Feb 2024 04:48PM UTC	22	91.01	GitHub Action Run

tari-project / tari-crypto / 7818206641
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7818206641

tari-project / tari-crypto / 7818206641 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7818206641

tari-project / tari-crypto / 7818206641
81%

README BADGES
x