basilisp-lang / basilisp / 7815485293

99%

push

github

align `rem` and `quot` methodologies with Clojure (#849)

Hi,

could you please consider patch to align the `rem` and `quot` results
with those of Clojure. It fixes #848.

This supersedes the decision to have `quot` use floored division
implemented #823.

This is to opt for full compatibility with Clojure, rather than using
numerically different but optimised python implementations. Users can
decide to use the corresponding python operators if they would like to
do otherwise.

I've also added some new test cases to cover additional results.

Thanks

---------

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1727 of 1730 branches covered (0.0%)

Branch coverage included in aggregate %.

8074 of 8172 relevant lines covered (98.8%)

0.99 hits per line