IntelPython / dpctl / 7794001184

86%

push

github

Fixes setting of writable flag for views and writing to read-only arrays with `out` keyword (#1527)

* Fixes bugs with `writable` flag setting

`writable` flag was not being set correctly for indexing, real views, imaginary views, tranposes, and where shape is set directly

Also fixes cases where flag could be overridden by functions with `out` kwarg

* Adds a test for writable flag view behavior

* Removes assumption that new array is writable

Now flags are set based on input regardless of whether a new array is writable
per review feedback

* Adds _copy_writable for copying the writable flag between arrays

* Correct typos in _copy_writable

* Fixes clip writing to read-only out arrays when min and max are none

2562 of 2821 branches covered (0.0%)

Branch coverage included in aggregate %.

7676 of 8425 relevant lines covered (91.11%)

4615.28 hits per line