josibake / rust-bitcoin / 7787517715

84%

push

github

Merge rust-bitcoin/rust-bitcoin#2442: Remove non_exhaustive from struct errors with pub inner

<a class=hub.com/josibake/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/josibake/rust-bitcoin/commit/8c17ad7fd7e8f82550030d19fdc7b98b3a485429">8c17ad7fd Remove non_exhaustive from struct errors with pub inner (Tobin C. Harding)

Pull request description:

  Using `non_exhaustive` as well as a public inner field is incorrect, it prohibits users from creating or matching on the error and does not achieve forward comparability.

  This was never right, we shouldn't have done it.

ACKs for top commit:
  Kixunil:
    ACK 8c17ad7fd7e8f82550030d19fdc7b98b3a485429
  apoelstra:
    ACK 8c17ad7fd7e8f82550030d19fdc7b98b3a485429

Tree-SHA512: 41266aaea3990c9d0bd7db90f2fc879d3e0

19326 of 22967 relevant lines covered (84.15%)

16850.12 hits per line