spesmilo / electrum / 5467313864966144
63%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 79
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.33% (-0.003%) from 59.333%
5467313864966144

push

CirrusCI

SomberNight 
trezor: fix regression in sign_transaction for trezor one for multisig

fixes https://github.com/spesmilo/electrum/issues/8813
regression from https://github.com/spesmilo/electrum/commit/eef968074

We started setting the witness field in above commit to be able to provide the witnesses for already pre-signed
external inputs to the device, e.g. for a coinjoin.

Trezor One fw has pretty strict limits on the witness field: max 109 bytes,
probably because that's a ~tight upper bound for a p2wpkh witness:
  <num_witness_items> <len(sig)> <sig> <len(pubkey)> <pubkey>, it comes out to 3+73(high-S and high-R)+33.
https://github.com/trezor/trezor-firmware/blob/ed1785a98/legacy/firmware/protob/messages-bitcoin.options#L35

Trezor model T seems to have higher limits.

tx_inputs is called for the tx being signed (for_sig=True), and for its parents/prev_txes (for_sig=False).
The witness is only useful for the tx being signed, I think.

Users reported seeing a "DataError: bytes overflow" exception when using a Trezor One to sign 2of3 p2wsh multisig txs.
There were no external inputs involved so for the tx being signed all witnesses were None, however we were also
setting the witness for the inputs of prev_txes.
The witness for a 2of3 pw2sh multisig input is around ~253 bytes.

To sidestep the problem, we now only set the witness in the for_sig=True case.
Note that this means if someone tries to do a coinjoin with a Trezor One involving non-trivial external inputs,
they will run into the same limit and exception.

19067 of 32137 relevant lines covered (59.33%)

2.96 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5467313864966144.1 0
59.19
2 5467313864966144.2 0
59.19
3 5467313864966144.3 0
59.23
4 5467313864966144.4 0
59.19
5 5467313864966144.5 0
59.22
Source Files on build 5467313864966144
Detailed source file information is not available for this build.