binary-com / deriv-app / 7736318530

54%

push

github

[TRAH] shontzu/TRAH-2643/Improve-MT5PasswordModal (#13010)

* chore: init refactor MT5PasswordModal

* refactor: make consistent mt5 and dxtrade PasswordModal code

* fix: small nit (FC ReactNode, etc)

* chore: code review

* fix: update CFD Provider with missing attributes

* chore: remove demo code from tradershubroute

* chore: using enums and remove unnecessary callback funcs

* refactor: show hide modal should be from modalProvider not CFDProvider

* fix: code review
 - removal of ModalStepWrapper
 - removal of hardcoded values
 - etc

* chore: small nit

* refactor: broken MT5PasswordModal into smaller component

* fix: useRegulationFlags and selectedJurisdiction as type TTM5FilterLandingCompany

* refactor: break down FooterComponent

* refactor: extract SuccessButtonGroup from SuccessComponent

* refactor: grouped button groups into a folder

* refactor: remove props drilling where it can be get from cfd context

* fix: add as const back to constants

* refactor: get isSuccess from CFDProvider insted of directly from api

* refactor: import useCreateMT5Account & useTradingPlatformPasswordChange in CFDProvider

* refactor: clean up CFDState
 - error, success, loading status from Accounts hook
 - get states from useMT5AccountHandler instead of CFDProvider

* fix: build

* chore: code review
 - enums
 - ternaries
 - type from api

* fix: build

* refactor: etracted repeating button code into a reusable component

* fix: marketType is undefined for dxtrade

* chore: replace DummyComponent with MT5PasswordModal

* fix: toggling SuccessComponent after PasswordComponent

* refactor: update TProps according to filename

* style: minor button style tweak

* chore: Category.DEMO

* chore: undo enums back to const

* chore: update react imports

* chore: demo flow

12307 of 38883 branches covered (0.0%)

Branch coverage included in aggregate %.

20259 of 55283 relevant lines covered (36.65%)

9.86 hits per line