zulip
/
zulip
/
2391
3%
|
Ran
|
Jobs
5
|
Files
237
|
Run time
6min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
timabbottupload: Use classes to define S3/Local upload backends. This has no functional changes; we just replace the old hacky assignment of functions with assignment of the upload backend to a variable. I'm not totally happy with this, because we end up having to copy the type annotations of the three methods 4 times each, but this should make it a lot easier to test the (non-default-in-tests) S3 backend using end-to-end tests, which would have caught 13bac1cc2. I expect we'll iterate on the interface over time; ideally, I'd like all the code that checks LOCAL_UPLOADS_DIR to be inside upload.py, and primarily in these classes.
13858 of 17128 relevant lines covered (80.91%)
0.81 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 2391.1 (TEST_SUITE=frontend) | 0 | Travis Job 2391.1 | ||
| 2 | 2391.2 (TEST_SUITE=backend) | 0 | Travis Job 2391.2 | ||
| 3 | 2391.3 (TEST_SUITE=production) | 0 | Travis Job 2391.3 | ||
| 4 | 2391.4 (TEST_SUITE=py3k) | 0 | Travis Job 2391.4 | ||
| 5 | 2391.5 (TEST_SUITE=mypy) | 0 |
80.91 |
Travis Job 2391.5 |
Source Files on build 2391
Detailed source file information is not available for this build.