couchbase / sync_gateway / 901
64%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 209
Run time 21s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.332% (+0.008%) from 63.324%
901

push

jenkins

web-flow 
CBG-3724 ensure import rollback works correctly (#6657)

* CBG-3724 ensure import rollback works correctly

Major fix: pass a function to call cbgt.JANITOR_ROLLBACK_PINDEX when
creating a pindex. This is necessary to ensure cbgt.Mgr will actually
generate the index.

- fix the TestImportRollback test which was giving a false pass before
  because the cbgt.Mgr was getting a kick op when the nodes were
  rebalanced. In order for rollback to work, the cbgt.Dest RollbackEx
  function has to force cgbt.Mgr to actually update the PIndex. A
  cbgt.JANITOR_ROLLBACK_PINDEX op will force the recreation of a PIndex.
  This test was broken before adding code to it.
- Enhance the TestImportRollback to detect a rollback with invalid FailoverLogs.
  This simulates a situation where the checkpoints have been migrated
  from a separate bucket.

- modify TestContinuousRollback to also test with bad vbuuid FailoverEntry.
  This test actually would pass, because Sync Gateway, unlike cbgt, did
  not pass DcpStreamAddFlagStrictVBUUID. DcpStreamAddFlagStrictVBUUID
  forces a rollback in the case where StartSeqNo=0 vbuuid=invalid
  whereas without the flag it is treated like StartSeqNo=0 vbuuid=0.
  Changed the code to match cbgt behavior adding
  DcpStreamAddFlagStrictVBUUID.
- Added a separate flag in DCPClient to detect active vBuckets, which
  are the number of vBuckets that actually have a connection, and are
  not stuck in a connecting state. This differs from the existing
  activeVbuckets which is set from the time of NewDCPClient to when the
  streams end. In a continuous feed, the streams should never end.

Cleanup:

- move RollbackEx function from DCPDest to DCPCommon. DCPCommon is an
  embedded struct in DCPDest.
- panic if DCPCommon.Rollback is called. This should never happen given
  the design of cbgt.Dest, but if it did, the rollback would not work.
  This is different from the old behavior where it would not rollback
  and ... (continued)

33421 of 52771 relevant lines covered (63.33%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 901.1 0
63.33
Source Files on build 901
Detailed source file information is not available for this build.