openSUSE / agama / 7710098085

72%

push

github

Adapt the web UI to use the Agama network service (#1006)

## Problem

The web UI still talks directly to NetworkManager to set up network
connections.

## Solution

This is the first set of changes aimed to stop using the NetworkManager
service from the web UI. Instead, it should talk to Agama's network
service (which relies on NetworkManager itself).

This pull request adapts the web UI to use Agama's network service to
write the changes (including connecting to wireless devices). However,
the status information is still retrieved from NetworkManager because
those bits are missing from our API.

During the process, we needed to introduce a few changes to Agama's
network service:

* Use UUIDs to identify connections instead of the Id (the name).
* Write only changed network connections.
* Rollback to the previous state if some connection cannot be updated.
* Better error handling at D-Bus level.

## Future

* Improve (almost non-existent) error handling.
* Retrieve the status information from Agama's network service.

## Testing

- *Adapted unit tests*
- *Tested manually*

1423 of 2168 branches covered (0.0%)

Branch coverage included in aggregate %.

16194 of 21476 relevant lines covered (75.41%)

22.4 hits per line