• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Qiskit / qiskit / 7701150273
90%
main: 88%

Build:
Build:
LAST BUILD BRANCH: add-pauli-lindblad-map-generators-15228
DEFAULT BRANCH: main
Ran 29 Jan 2024 07:23PM UTC
Jobs 1
Files 911
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Jan 2024 07:04PM UTC coverage: 89.513% (-0.02%) from 89.536%
7701150273

push

github

web-flow
Reimplement two_qubit_decompose.num_basis_gates in rust (#11019)

* Use newer rust

* Adding weyl chamber code in rust

* Finish num_basis_gates in rust, but calculated values wrong

* Fix bugs in weyl_coordinates

* Upgrade faer from 0.12 to 0.13

* This will allow copyless convert of numpy complex matrix to faer
* abs2 disappeared probably an error, so we work around here.

* Use copyless conversion of complex matrix from numpy to faer

* Fix thinko bugs so that existing tests pass

* Add comment

* Remove allocation

* Replace loop with iterator

* Silence clippy complaints

* refactor

* Run rustfmt

* Slight refactor and format

* Reorganize new code in crate accelerate

* Moved `eigenvalues` into module `utils`.
* Access num_basis_gates via module two_qubit_decompose

* Remove some allocations

* Run rustfmt

* Raise faer version to 0.13.5, lower rustc to 1.67.0

faer 0.13.5 introduces a specific MSRV

* Fix some conflicts with main branch

* Fix more conflicts

* More conflicts

* More conflicts

* Update crates/accelerate/src/two_qubit_decompose.rs

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Apply suggestions from code review

Apply several suggested edits made in review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Increase faer version and remove some cruft

* We introduced to_num_complex, but this required upgrading faer. We chose 0.15
* Upgrade our code, in turn, for the upgrade to faer 0.15
* Remove a function exported via pyo3 that was only used for testing
* Remove `def old_num_basis_gate`

* Make __num_basis_gates more idiomatic

* Explain use of `min_by` when `max_by` is expected

* Replace myabs2 with faer_abs2

We recently increased the version of the faer dependency.
The newer version has an abs2 in the api named `faer_abs2`.

So we can delete `myabs2`.

* Use alternative mod implementation following review requests

* Make pyo3 function eigenvalues return ndarray rather than list

Following review s... (continued)

59646 of 66634 relevant lines covered (89.51%)

219177.32 hits per line

Jobs
ID Job ID Ran Files Coverage
1 7701150273.1 29 Jan 2024 07:23PM UTC 0
89.51
GitHub Action Run
Source Files on build 7701150273
Detailed source file information is not available for this build.
  • Back to Repo
  • 11a826b9 on github
  • Prev Build on gh-readonly-queue/main/pr-11663-5ebf7f1251049ff28c495678d4a37912385164ec (#7699712536)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc