ckeditor / ckeditor5 / 74ef3de9-4e6a-431d-a9e3-437af483eea9

100%

push

circleci

Merge pull request #15688 from ckeditor/ck/4517

Fix (engine): The `style` and `class` attributes conversion should work with `attributeToAttribute()`. Closes #4517.

MINOR BREAKING CHANGE (engine): In the `attributeToAttribute()` upcast helper we fixed how the missing `value` of the `"class"` and `"style"` attribute conversion is handled. Now while not providing the attribute's `value` to the conversion helper accepts and consumes all values. Previously those values were not consumed and left for other converters to convert. Note that you should use the `classes`, and the `styles` fields for the fine-tuned conversion of those attributes instead of a catch-all `"style"` and `"class"` specified in the `key` field.

13130 of 13130 branches covered (100.0%)

Branch coverage included in aggregate %.

34529 of 34529 relevant lines covered (100.0%)

11423.73 hits per line