rust-bitcoin / rust-bitcoin / 7689065448

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2408: Provide `Amount` & co in no-alloc

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ac26171c326e012cc6ea9ee3665941782dd608ff">ac26171c3<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d883c3d5a27be78a38649c2ed298ce462c2c6a89"> Clean up `no_std` usage (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fce03cec85f0ee8d27604738c3d0120aa6e4d782">fce03cec8</a> Provide `Amount` & co in no-alloc (Martin Habovstiak)

Pull request description:

  Using the crate without allocation was previously disabled making the
  crate empty without the feature. This chage makes it more fine-grained:
  it only disables string and float conversions which use allocator. We
  could later provide float conversions by using a sufficiently-long
  `ArrayString`.

  Note that this is API-breaking because we disallow calling the methods of the sealed `SerdeAmount` trait. However I think it should've been obvious that the thing is internal and calling them is not a great idea. (BTW I only learned this trick recently).

  Closes #2389

ACKs for top commit:
  apoelstra:
    ACK ac26171c326e012cc6ea9ee3665941782dd608ff maaybe `private` should be renamed to `internal_api` or something
  tcharding:
    ACK ac26171c326e012cc6ea9ee3665941782dd608ff

Tree-SHA512: 2ca2ff11c2e8028bc47c8f4afea63018e9f

19315 of 22910 relevant lines covered (84.31%)

16781.32 hits per line