rust-bitcoin / rust-bitcoin / 7668596887

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2370: Improve units

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7bf478373a343ca0a4a89d49225ab58a5f6eb196">7bf478373<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e2b9555070d9357fb552e56085fb6fb3f0274560"> Model `TooBig` and `Negative` as `OutOfRange` (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/54cbbf804fc6fbcaff65bdfb1345191d77618edd">54cbbf804</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e2b9555070d9357fb552e56085fb6fb3f0274560"> Express `i64::MAX + 1` as `i64::MIN.unsigned_abs()` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b562a18914fef1dbac6a451c37c753776840bc5c">b562a1891</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e2b9555070d9357fb552e56085fb6fb3f0274560"> Move denomination error out of `ParseAmountError` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5e6c65bc1a8da337a57b11987f72ec77a2d878e2">5e6c65bc1 Clean up `unsigned_abs` (Martin Habovstiak)

Pull request description:

  Closes #2265
  Closes #2266

  Disclaimer: I did this in December and don't remember why I haven't pushed it. Maybe because it's somehow broken but I don't see how so please review a bit more carefully just in case.

ACKs for top commit:
  tcharding:
    ACK 7bf478373a343ca0a4a89d49225ab58a5f6eb196
  apoelstra:
    ACK 7bf478373a343ca0a4a89d49225ab58a5f6eb196

Tree-SHA512: 1f6e9adae709ac9eca8d5029f5b90745570

19313 of 22908 relevant lines covered (84.31%)

16868.54 hits per line