rust-bitcoin / rust-bitcoin / 7656454620

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2402: Remove TODOs

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5eb2de16609f2c6aadff640f2f4b2cacac83fa9c">5eb2de166<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> Remove TODO about rand trait (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/66cc007c2bd56423862a935b8305a3246f68fff3">66cc007c2</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> p2p: Remove TODO comments (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0b5fb45ea00e5870143f9270d0a8cdc97e4c5d4a">0b5fb45ea</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> consensus: Remove HEX_BUF_SIZE todo (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/579668892ab454003e8f91d4dddc3372a697e1a9">579668892</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> consensus: Remove TODO (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/53beb9db30f828f6ecb3710a761e2f8d6cf3feb2">53beb9db3</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> Remove ancient todos in test code (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/abe22418289bdf590acf19065d699a169f97f667">abe224182</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6bd837595909af7a21077a5e3143e6d6e3afc414"> units: Remove "alloc" TODO (Tobin C. Harding)
5386ef0fd psbt: Delete TODO comments (Tobin C. Harding)
14c8a2232 examples: Remove TODO (Tobin C. Harding)

Pull request description:

  Done while working on #2368.  There are 5 left. Do we want to leave the MSRV ones in there?

  ```bash
  bitcoin/src/blockdata/weight.rs:66:                 // TODO replace with panic!() when MSRV = 1.57+
  bitcoin/src/consensus/serde.rs:101:    // TODO: statically prove impossible cases
  bitcoin/src/pow.rs:445:            // TODO: Use `carrying_mul` when stabilized: https://github.com/rust-lang/rust/issues/85532
  units/src/amount.rs:595:        // TODO replace whith unwrap() when available in const context.
  units/src/amount.rs:599:                // TODO replace with panic!() when MSRV = 1.57+
  ```

ACKs for top commit:
  Kixunil:
    ACK 5eb2de16609f2c6aadff640f2f4b2cacac83fa9c
  apoelstra:
    ACK 5eb2de16609f2c6aadff640f2f4b2cacac83fa9c

Tree-SHA512: 285b1711ab76fde1d3133da177c1027ec8e

19240 of 22826 relevant lines covered (84.29%)

16982.54 hits per line