sonata-project / SonataDoctrineORMAdminBundle / 1108

75%

push

travis-ci

Ensure DoctrineType is available before using it (#586)

PR #547 brought other identifier types support.

This uses Type::getType method with ClassMetada::getTypeOfField returned value.

ClassMetada::getTypeOfField can return null and then Type::getType throw an exception.

This can be reproduced with an entity having a relation as an identifier.

Plus, the given type field may be not mapper under Type map.

Checking ClassMetada::getTypeOfField return value and use Type::hasType before solve the issue.

4 of 4 new or added lines in 2 files covered. (100.0%)

329 of 1356 relevant lines covered (24.26%)

12.96 hits per line