• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opentrials / opentrials / 284
100%

Build:
DEFAULT BRANCH: master
Ran 09 Jun 2016 11:32AM UTC
Jobs 1
Files 40
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
284

push

travis-ci

vitorbaptista
[#209] Fix bugs with published results filter

If `has_published_results == false`, we weren't adding any filters, so we would
get all trials (including those with published results). This is because we
relied on simply testing for truthyness, and not for the actual true/false
value. As `undefined` is falsy in JavaScript, there was no difference between
setting `has_published_results = false` and not setting `has_published_results`
at all.

I've also fixed the bug where the study results filter wasn't persistent. The
problem here is that we were testing for "true" and "false" strings, and not
boolean values. This was the case before we added Joi for validation. As Joi
also converts the values, it stopped working.

515 of 515 relevant lines covered (100.0%)

13.33 hits per line

Jobs
ID Job ID Ran Files Coverage
1 284.1 09 Jun 2016 11:32AM UTC 0
100.0
Travis Job 284.1
Source Files on build 284
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #284
  • 18194623 on github
  • Prev Build on master (#283)
  • Next Build on master (#285)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc