blues / note-c / 7617388538

93%

push

github

Fix timeout data type bugs. (#131)

This commit resolves a couple problems.

First, it changes the return type of NoteGetMs. NoteGetMs is simply a wrapper
around the user-supplied millisecond timer hook. The prototype for this hook
specifies that it should return a uint32_t yet NoteGetMs's return type is long
unsigned int. This commit changes the return type of NoteGetMs to uint32_t.

Second, there are many places in the code where we are comparing and assigning
millisecond timer values (i.e. gotten via NoteGetMs) to size_t variables. This
is a bug. On some platforms (e.g. the Arduino Uno), size_t is 16 bits, so
assigning one of these 32-bit millisecond timer values to a 16-bit variable can
lead to undefined behavior when the timer value is larger than what can fit into
16 bits. This commit fixes all these bugs by using uint32_t instead of size_t.

988 of 1201 branches covered (0.0%)

Branch coverage included in aggregate %.

2108 of 2215 relevant lines covered (95.17%)

80.61 hits per line