rust-bitcoin / rust-bitcoin / 7616194895

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2336: units: Enable parsing Amount from `u64::MAX`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b2344e019d18c8580e7fa11a1e6aa9615b05babf">b2344e019<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d08d3efdfa58ee8f63b141a89ec7ec04c3894e42"> units: Assert roundtrip SignedAmount/str overflows (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/baadcf4c0af7c3530824f18241c544ee19f92bc7">baadcf4c0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d08d3efdfa58ee8f63b141a89ec7ec04c3894e42"> units: Test that SignedAmount float conversion overflows (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d768f25da8e31aa63764c6cf5c92d4c1e5f2b12e">d768f25da</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d08d3efdfa58ee8f63b141a89ec7ec04c3894e42"> units: Remove duplicate assertion (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1d536ac8b292cf17f9acd0b75b733ad9c905eb35">1d536ac8b</a> units: Enable parsing Amount from u64::MAX (Tobin C. Harding)

Pull request description:

  Our `Amount` type uses an internal `u64` and we maintain no invariants on the inner value. Therefore we should be able to parse `u64::MAX`.

  Fix the parsing code by removing the explicit, incorrect check and fix unit tests to mirror this behaviour.

  Fix: #2297

ACKs for top commit:
  Kixunil:
    ACK b2344e019d18c8580e7fa11a1e6aa9615b05babf
  apoelstra:
    ACK b2344e019d18c8580e7fa11a1e6aa9615b05babf

Tree-SHA512: 944f8d0bf4c4c032d00d7bdf6470ac963f6

19221 of 22812 relevant lines covered (84.26%)

16929.62 hits per line