ooni / probe-cli / 7611699369
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 531
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.311% (-0.03%) from 81.343%
7611699369

push

github

web-flow 
feat(webconnectivitylte): handle ghost DNS censorship (#1457)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/2652
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: no need
- [x] if you changed code inside an experiment, make sure you bump its
version number: already bumped for 3.21.x

## Description

This commit modifies webconnectivitylte to handle ghost DNS censorship.

We define ghost DNS censorship the case where the original domain does
not exist anymore but the censor continues to return an IP address for
the original domain nonetheless.

We used to have null-null handling for this case in the "orig" engine
and a reference issue as https://github.com/ooni/probe/issues/2307.

With this commit, we modify the "classic" engine to correctly handle
this case.

To this end, we need to:

1. mark DNS inconsistency when we have successful probe lookups and no
IP address has been resolved by the test helper, which is indeed the
case of ghost DNS censorship.

2. specific handling on the case in which the website seems down where
we also ask ourselves the question of whether the culprit could be the
DNS and otherwise set accessible = false and blocking = false.

Note that, with those two changes, we depart from strict
v0.4-is-always-right orthodoxy.

So, while there, let's recognize that always setting
HTTPExprimentFailure is probably for the greater good.

25099 of 30868 relevant lines covered (81.31%)

41.67 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 7611699369.1 0
81.31
 GitHub Action Run
Source Files on build 7611699369
Detailed source file information is not available for this build.