22909
82%

Ran 15 Jan 2024 02:41PM UTC

Jobs 1

Files 259

Run time 20s

Badge

Embed ▾

Committed 15 Jan 2024 02:35PM UTC coverage: 82.429% (+0.5%) from 81.948%

Build # 22909

Build Type

push

circleci

Committed by

web-flow

Commit Message

Integrate CFE-Civil for doing eligibility check (#1082)

What? Integration of CFE-Civil with CLA. When CLA does an eligibility check (means test), instead of doing the calculation internally, this PR changes it to call CFE-Civil's API and use that result.

Why? This has the benefit of outsourcing the complicated calculations to being Eligibility Platform's responsibility. They worry about making the calculation accurate, and updating it over time to cope with changes to the thresholds etc and Means Test Review (although that will have some changes to the UI too).

Detail
This PR has several parts:

The eligibility check (EligibilityChecker.is_eligible()) now calls CFE-Civil to do the calculation, instead of using CLA's existing code in calculator.py.

move original CLA eligibility checker into '_legacy_check' method (which we intend to delete in a follow-up PR)

Added '_translate_case()' which converts a case from CLA's data model, to CFE Civil's data model:

CLA's CaseData has been analysed by us and recorded in: CaseData field definitions
CFE-Civil's assessments API is defined in Swagger: CFE-Civil API docs

Run Details

7839 of 9510 relevant lines covered (82.43%)

0.82 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	22909.1	15 Jan 2024 02:42PM UTC	0	82.43	CircleCI Job

Source Files on build 22909

Detailed source file information is not available for this build.

ministryofjustice / cla_backend / 22909
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 22909

ministryofjustice / cla_backend / 22909 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 22909

ministryofjustice / cla_backend / 22909
82%

README BADGES
x