7496082017
89%

Ran 12 Jan 2024 12:15AM UTC

Jobs 1

Files 80

Run time 5s

Badge

Embed ▾

Committed 11 Jan 2024 10:55PM UTC coverage: 89.606% (-0.006%) from 89.612%

Build # 7496082017

Build Type

push

github

Committed by

web-flow

Commit Message

Fix `Marshal7951` for direct union leaf calls. (#947)

When `jsonValue` is called using the output of `reflect.ValueOf()` instead of
`reflect.StructField`, any interface type is lost through re-packing to the
empty interface (any). This means the `reflect.Kind` of a union field is no
longer the union type, but instead its underlying concrete type. The current
code doesn't handle this case, leading to runtime errors.

This handling code is now added, with a couple more fixes related to `empty`
types.

-----
Tested manually that the following ygnmi call is no longer affected by the
original error:
```go
sp := gnmi.OC().NetworkInstance("DEFAULT").Protocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_STATIC, "STATIC")
return ygnmi.Replace(context.Background(), c, sp.Static("1.1.1.1/32").SetTag().Config(), oc.NetworkInstance_Protocol_Static_SetTag_Union(oc.UnionUint32(42)))
```

Run Details

13906 of 15519 relevant lines covered (89.61%)

487.2 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7496082017.1	12 Jan 2024 12:15AM UTC	80	89.61	GitHub Action Run

openconfig / ygot / 7496082017
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7496082017

openconfig / ygot / 7496082017 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7496082017

openconfig / ygot / 7496082017
89%

README BADGES
x