microsoft / teams-ai / 7465867365

80%

push

github

[JS] feat: Removed Deprecated Completions Logic, Added OpenAIClient and AzureOpenAIClient Unit Tests, Updated Response/Request Parameters (#1138)

## Linked issues

closes: #1136, #54 

## Details

- Updated `createEmbeddings` with missing `model` parameter 
- Added unit tests for `OpenAIClient` and `AzureOpenAIClient`
- Fixed model bug (Previously was appending an empty string to the URL
if it wasn't specified)
- Added missing header `Ocp-Apim-Subscription-Key` to enable calls to
Azure Content Safety
- Removed deprecated `Completions` logic - [More info
here](https://platform.openai.com/docs/api-reference/completions)
- Updated request/response parameters (optional, new fields, and
deprecated fields)
- Created a [ticket ](https://github.com/microsoft/teams-ai/issues/1137)
for updating moderation parameters and do a general cleanup of the
`types` file. I didn't make these changes in this PR since it'll require
logic changes as well (incl in C#), and there's quite a number of fixes
here already.

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

2146 of 3720 branches covered (0.0%)

Branch coverage included in aggregate %.

5276 of 7547 relevant lines covered (69.91%)

21.75 hits per line