Ran
|
Jobs
3
|
Files
376
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Fixed plugin installation table columns width (#5161) Summary: the issue was that in the plugin installation popup table, the columns had a width of 0, making it impossible to see any data and the install/uninstall button. This PR addresses the issue https://github.com/facebook/flipper/issues/5124 <img width="1379" alt="Screenshot 2023-09-21 alle 16 46 19" src="https://github.com/facebook/flipper/assets/29179493/cf14a3b2-7385-4677-ade8-9e23108ca9ec"> After the fix <img width="1379" alt="image" src="https://github.com/facebook/flipper/assets/29179493/08caacf4-8326-429e-bd9c-a50feb55cea6"> I resolved the issue by moving the constants declaring the column widths inside the component, which previously caused the columns to have a width of 0 in the plugin installation popup table. ## Changelog Pull Request resolved: https://github.com/facebook/flipper/pull/5161 Reviewed By: antonk52 Differential Revision: D52599827 Pulled By: passy fbshipit-source-id: 175163b5e
4075 of 9098 branches covered (0.0%)
Branch coverage included in aggregate %.
1 of 1 new or added line in 1 file covered. (100.0%)
22 existing lines in 3 files now uncovered.8231 of 14750 relevant lines covered (55.8%)
278.19 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
2 |
75.0 |
-18.75% | desktop/flipper-ui/src/ui/components/table/utils.tsx |
3 |
31.02 |
-1.49% | desktop/flipper-ui/src/ui/components/table/ManagedTable.tsx |
17 |
49.04 |
-13.78% | desktop/flipper-ui/src/ui/components/table/TableHead.tsx |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 7460662510.1 | 376 |
51.59 |
GitHub Action Run | |
2 | 7460662510.2 | 376 |
51.56 |
GitHub Action Run | |
3 | 7460662510.3 | 376 |
51.59 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|