018cea9c-476d-4453-9622-9fd64fd53757
72%

Ran 08 Jan 2024 08:17PM UTC

Jobs 1

Files 662

Run time 1min

Badge

Embed ▾

Committed 08 Jan 2024 07:45PM UTC coverage: 62.296% (+5.2%) from 57.123%

Build # 018cea9c-476d-4453-9622-9fd64fd53757

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Properly catch errors in ldflag-gathering and fail the build (#5539)

The dubious-ownership issue in CI appears to be happening here too,
and might be why some builds have "unknown" as their commit SHAs.

Building this change locally properly fails to build binaries when
it cannot be gathered, and includes the data when it can:
```
VERSION:
   CLI feature version: 1.7.0
   Release version: v1.2.7-prerelease2-dirty
   Build commit: 2023-12-22T20:30:21+00:00-d4d205fe3
```

---

Previously there were basically three issues at play:
- git's new `safe.directory` thing, now applied everywhere rather than just one target
- the in-variable-expansion shell error would be swallowed and
(AFAICT) be completely undetectable elsewhere in Make.
- [SC2155](https://github.com/koalaman/shellcheck/wiki/SC2155) and similar "you captured output but you also suppressed the error code" issues in scripts.

Since fixing the "always include the version, fail build if it does not work" issue
involved discovering and fixing all three, they're all in this commit.

Run Details

93415 of 149954 relevant lines covered (62.3%)

2258.7 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	018cea9c-476d-4453-9622-9fd64fd53757.1	08 Jan 2024 08:17PM UTC	662	62.3

uber / cadence / 018cea9c-476d-4453-9622-9fd64fd53757
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018cea9c-476d-4453-9622-9fd64fd53757

uber / cadence / 018cea9c-476d-4453-9622-9fd64fd53757 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018cea9c-476d-4453-9622-9fd64fd53757

uber / cadence / 018cea9c-476d-4453-9622-9fd64fd53757
72%

README BADGES
x