7447434470
37%
master: 38%

Ran 08 Jan 2024 12:32PM UTC

Jobs 1

Files 143

Run time 9s

Badge

Embed ▾

Committed 08 Jan 2024 12:27PM UTC coverage: 37.131%. Remained the same

Build # 7447434470

Build Type

push

github

Committed by

tom93

Commit Message

Render 404 Not Found for invalid problem filelink path

Previously, /problems/:id/files/download/:path with a non-existent
path would crash with Pundit::NotDefinedError (unable to find policy
of nil), because `find_by_filepath` returns nil if the record is not
found and then `authorize @filelink, :show?` fails.

Full error trace:

```
Completed 500 Internal Server Error in 311ms (ActiveRecord: 30.2ms)
unable to find policy of nil excluded from capture: DSN not set

Pundit::NotDefinedError (unable to find policy of nil):
  app/controllers/filelinks/roots_controller.rb:61:in `show'
```

Run Details

2239 of 6030 relevant lines covered (37.13%)

5.61 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7447434470.1	08 Jan 2024 12:32PM UTC	143	37.13	GitHub Action Run

NZOI / nztrain / 7447434470
37%
master: 38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7447434470

NZOI / nztrain / 7447434470 37% master: 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7447434470

NZOI / nztrain / 7447434470
37%
master: 38%

README BADGES
x