openSUSE / agama / 7446896756

72%

push

github

Remove global issues page and start using popup instead (#886)

## Problem

"We have agreed to use the sidebar for actions related to the installer
itself (e.g., diagnosis tools, display lang, etc). Everything related to
the target system to install should not be placed in the siderbar.

The only thing related to the target system still present in the sidebar
is the issues link. The issues should be globally accessible from
another place (footer, header, ...)."

As described in #872 

This PR fixes #872 

## Solution

Issues page link is removed from the sidebar and all other places where
it was present.

During the progress of this PR, decision was made to drop the showing of
global (all) issues at once in the popup.

Because of this, the Issues popup (previously a page) can no longer be
accessed from the sidebar (or from the icon in the header, which was an
idea at some point).

The Issues Dialog (popup) now shows issues related only to a single
section (software, product, storage, ...) and is opened by clicking on
the warning link in the sections on the overview page (and a few other
places).

For this reason, the prop id for the Section component was introduced,
so the issues could be filtered to a specific type for the popup based
on from where has the user clicked the warning.

## Testing

-  Tested manually
- Adjusted unit test files to some extent, possibly more work is needed
here.


## Screenshots


![294189450-e2b43bbc-65cb-42bb-aa64-092eb8e2b0f5](https://github.com/openSUSE/agama/assets/112288843/0177753e-c96b-42d4-a10e-7543b570104a)

1418 of 2158 branches covered (0.0%)

Branch coverage included in aggregate %.

15988 of 21070 relevant lines covered (75.88%)

22.37 hits per line