7442844147
74%
BABEL_5_X_DEV: 77%

Ran 08 Jan 2024 03:58AM UTC

Jobs 1

Files 113

Run time 10s

Badge

Embed ▾

Committed 08 Jan 2024 03:27AM UTC coverage: 72.285% (+0.01%) from 72.272%

Build # 7442844147

Build Type

push

github

Committed by

web-flow

Commit Message

Support 'DROP INDEX table.index' and 'DROP INDEX ix ON schema.table' (#2216)

To support the syntax DROP INDEX table.index, the statement is rewritten in ANTLR as DROP INDEX index ON table, which is picked up by the backend parser.

To support the syntax DROP INDEX schema.table.index and DROP INDEX index ON schema.table, the statement is rewritten in ANTLR as DROP INDEX index ON table SCHEMA schema, which is picked up by the backend parser. Adding the SCHEMA clause for this case was necessary to avoid Bison reduce conflicts which resulted from seemingly more straightforward syntax options. 

In the backend parser, the trick is then to create an object reference in the DropStmt structure for the schema-qualified index with the schema name from the SCHEMA clause that was added, since PG's DROP INDEX only references the index, instead of its table like in T-SQL.

Also, proper error messages are now raised when attempting DROP INDEX with a 3-part of 4-part name.

Signed-off-by: Rob Verschoor rcv@amazon.com
Issues Resolved

BABEL-1483 Support DROP INDEX table.index syntax
BABEL-1652 Support DROP INDEX ix ON schema.table syntax

Run Details

39697 of 54917 relevant lines covered (72.29%)

57238.21 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7442844147.1	08 Jan 2024 03:58AM UTC	113	72.29	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 7442844147
74%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7442844147

babelfish-for-postgresql / babelfish_extensions / 7442844147 74% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7442844147

babelfish-for-postgresql / babelfish_extensions / 7442844147
74%
BABEL_5_X_DEV: 77%

README BADGES
x