• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jlfwong / speedscope / 7402382129
44%
master: 47%

Build:
Build:
LAST BUILD BRANCH: jlfwong/copy-summary-text
DEFAULT BRANCH: master
Ran 03 Jan 2024 09:05PM UTC
Jobs 2
Files 84
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Jan 2024 09:04PM UTC coverage: 43.619% (+0.1%) from 43.524%
7402382129

push

github

web-flow
Partition based on samples instead of traceEvents when importing a sample-based chrome trace (#460)

In the existing code, if `traceEvents` did not have any importable events, the profile would be marked as empty. This was a bug, as the dev Hermes profiles I was testing with had one X event which made the code work. However we do not need to guarantee (and the spec doesn't seem to) any traceEvents being present as long as we have samples and stack frames. 

When I tested a production profile taken from Hermes it did not have any importable events, just a metadata event with a thread name. This PR updates the implementation to iterate over partitioned samples instead of traceEvents so we construct profiles for all thread + process pairs referenced in the samples array.

| Before | After |
| --- | ----- |
| <img width="1454" alt="Screenshot 2024-01-03 at 9 58 56 AM" src="https://github.com/jlfwong/speedscope/assets/9957046/78c098a7-b374-4492-ad13-9ca79afdb40c"> | <img width="1450" alt="Screenshot 2024-01-03 at 9 58 17 AM" src="https://github.com/jlfwong/speedscope/assets/9957046/d2d5e82b-fa3e-43db-bf8a-e8c3b84cd13a"> |

1180 of 2805 branches covered (0.0%)

Branch coverage included in aggregate %.

2706 of 6104 relevant lines covered (44.33%)

4020.02 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-20.x - 7402382129.1 03 Jan 2024 09:05PM UTC 0
43.62
GitHub Action Run
2 run-18.x - 7402382129.2 03 Jan 2024 09:05PM UTC 0
43.62
GitHub Action Run
Source Files on build 7402382129
Detailed source file information is not available for this build.
  • Back to Repo
  • a6d70019 on github
  • Prev Build on main (#7344561777)
  • Next Build on main (#7505718737)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc