7397931991
84%

Ran 03 Jan 2024 01:33PM UTC

Jobs 1

Files 3

Run time 1s

Badge

Embed ▾

Committed 03 Jan 2024 01:21PM UTC coverage: 89.59% (+0.02%) from 89.573%

Build # 7397931991

Build Type

push

github

Committed by

bokwoon95

Commit Message

fix chained commands proceeding even on error

Regression introduced in b92c757: the atomic bool was erroneously
replaced with closing the cmdResult channel. When the cmdResult channel
is closed, subsequent reads will keep yielding the zero value (a nil
error in this case). Therefore failed commands which should rightfully
break the chain end up proceeding anyway because first it fails, then it
"succeeds" (because select{} on the closed channel produces a zero
value). Fixed by introducing an additional channel waitDone which is
used to actually signal when a command is done.

Run Details

525 of 586 relevant lines covered (89.59%)

35.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7397931991.1	03 Jan 2024 01:33PM UTC	0	89.59	GitHub Action Run

Source Files on build 7397931991

Detailed source file information is not available for this build.

bokwoon95 / wgo / 7397931991
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7397931991

bokwoon95 / wgo / 7397931991 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7397931991

bokwoon95 / wgo / 7397931991
84%

README BADGES
x