ledgersmb / LedgerSMB / 7355627173

63%

push

github

Remove App_State::User (#7876)

* Parse numbers coming in from the web UI in $request

This reduces a hidden dependency on $LedgerSMB::App_State::User through PGNumber

* Less coerce-magic

For LedgerSMB::Moose::Number, this magic secretly depends on the App_State::User magic...

* Fix thinko: parse_amount/date must *parse* the input

* Further reduce the dependency on coercing strings to numbers (and dates)

Which in turn further reduces the dependency on App_State::User.

* Remove coerce-support for PGNumber to eliminate conversion magic

* Simplify PGNumber->from_input now that it doesn't depend on App_State::User

* Fix tests

* Definitively remove use of 'numberformat' from App_State::User

* Remove coerce-support for PGDate

* Fix tests. Fix setup.pl

* Remove LedgerSMB::App_State::User

* Add documentation

111 of 184 branches covered (0.0%)

9569 of 20244 relevant lines covered (47.27%)

489.73 hits per line