openSUSE / agama / 7338819966

72%

Build Type

push

github

Committed by web-flow

Commit Message

Improve D-Bus network interface (#961)

## Problem

Until now, the communication between our network model and its D-Bus
interface worked only in one direction (from D-Bus to the model). And
that was pretty limiting.

## Solution

In #885 we introduce the usage of `oneshot::channel()` to enable
bi-directional communication between the model and the D-Bus interface.
It worked rather well, so it is time to extend this approach.

Some use cases that are covered:

* Perform a complex validation in the model (considering the whole
model) and return the result to the D-Bus interface.
* Return the D-Bus path of a new connection (implemented in this PR).

But there is another interesting implication: the model is the single
source of truth (no more cloned data in the interface). In the future,
we are expected to listen to NetworkManager and update some parts of our
model accordingly. Not having to replicate that information to D-Bus
(except when new things add or disappear) makes things easier.

Note: `org.opensuse.Agama1.Network.Device` and
`org.opensuse.Agama1.Network.Devices` are excluded by now.

## Testing

- *Added a new unit test*
- *Tested manually*


## To do

- [x] Reduce the boilerplate associated to the usage of channels.

Run Details

1426 of 2171 branches covered (0.0%)

Branch coverage included in aggregate %.

248 of 292 new or added lines in 8 files covered. (84.93%)

3 existing lines in 2 files now uncovered.

16050 of 21133 relevant lines covered (75.95%)

22.63 hits per line