openSUSE / agama / 7298419110

72%

push

github

[web] Does not mangle names ending in PageMenu (#950)

## Problem

`core/Page` component changed a lot in #925 and got _the ability_ to
work with it's children in order to been able to extract some of them
for placing in the right place.

It's the case of the `Page.Actions` and `Page.Menu`, but while the
former are extracted by checking their `type`, for the latest it's
needed to relay on their `type.name` since they can be wrapped in
another component due to their potential complexity.

Thus, it was required that components intended to be used as page menus
were named ending in _PageMenu_, but this does not work as expected when
minification comes into scene.

## Solution

Until we have something better, the solution by now is asking
[TerserWebpackPlugin](https://webpack.js.org/plugins/terser-webpack-plugin/)
to keep functions names for these functions (aka components) ending in
_PageMenu_. A few bytes more for the production build, but in exchange
everything works as expected.

Fixes #949 

## Testing

Tested manually

## Screenshots

|Before | After |
|-|-|
|![Page Menu
missplaced](https://github.com/openSUSE/agama/assets/1691872/dbfe338b-751c-4110-ab8b-6f5f7a68fc5a)
| ![Page Menu in
place](https://github.com/openSUSE/agama/assets/1691872/b0fd3638-47cc-42ec-a3d9-b07751227862)
|

1426 of 2171 branches covered (0.0%)

Branch coverage included in aggregate %.

15998 of 21082 relevant lines covered (75.88%)

22.63 hits per line