Unleash / unleash-client-go / 7285437228

80%

v3: 86%

Build Type

push

github

Committed by web-flow

Commit Message

fix: variant fallback usage (#171)

This PR fixes a bug in how we use fallback variants in this SDK.

The fallback should be used when there is no flag, when the flag doesn't have any variants, and if the flag has variants, but is disabled. However, prior to this, it was only used if the flag didn't exist.

It addresses the issues in and closes #160.

* fix: add tests and impl

* fix: update comments

* fix: minor rename

* fix: use noopListener

* fix: don't change the "FeatureEnabled" state of the fallback variant

* Chore: remove empty struct from list

* Test: ensure that the fallback variant's `FeatureEnabled` is unchanged

* Docs: add notes about `FeatureEnabled` to function docs

Run Details

9 of 10 new or added lines in 1 file covered. (90.0%)

1 existing line in 1 file now uncovered.

1251 of 1571 relevant lines covered (79.63%)

279.33 hits per line