Qiskit / qiskit / 7282035075

88%

Build Type

push

github

Committed by web-flow

Commit Message

Track `QuantumCircuit.global_phase` in `ParameterTable` (#11428)

* Track `QuantumCircuit.global_phase` in `ParameterTable`

We have previously always had a split where circuit parameters used in
instructions were tracked in the `ParameterTable`, but any parameters
used in the global phase were not.  Any method that influenced the
parameters needed to separately check the global phase, and merge that
information with that in the `ParameterTable`.  This made it easy to
forget, or easy for the handling of it to become out of sync.

This commit now tracks the global phase as part of the `ParameterTable`,
so this object is now the canonical source of parameter information for
the circuit (outside the context of calibrations, which are handled
entirely separately).  The `ParameterTable` is an internal detail, and
only accessible through private attributes, so is not part of the public
interface.

* Restore mutation warning

* Restore newline

Run Details

40 of 49 new or added lines in 2 files covered. (81.63%)

10 existing lines in 2 files now uncovered.

59168 of 67602 relevant lines covered (87.52%)

278597.03 hits per line