openSUSE / agama / 7251636875

72%

Build Type

push

github

Committed by web-flow

Commit Message

Use YAML.safe_load_file instead of YAML.safe_load (#939)

## Problem

For some reason that I have not been able to find, I am facing a problem
when loading the products definition:

```
bundler: failed to load command: bin/agamactl (bin/agamactl)
/usr/lib64/ruby/3.2.0/psych/parser.rb:62:in `_native_parse': (<unknown>): control characters are not allowed at line 1 column 1 (Psych::SyntaxError)
	from /usr/lib64/ruby/3.2.0/psych/parser.rb:62:in `parse'
	from /usr/lib64/ruby/3.2.0/psych.rb:455:in `parse_stream'
	from /usr/lib64/ruby/3.2.0/psych.rb:399:in `parse'
	from /usr/lib64/ruby/3.2.0/psych.rb:323:in `safe_load'
	from /home/suse/agama/service/lib/agama/product_reader.rb:63:in `load_file'
	from /home/suse/agama/service/lib/agama/product_reader.rb:50:in `block in load_products'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `each'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `each_with_object'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `load_products'
	from /home/suse/agama/service/lib/agama/config.rb:102:in `products'
	from /home/suse/agama/service/lib/agama/config.rb:83:in `data'
	from /home/suse/agama/service/lib/agama/config.rb:139:in `merge'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `block in config'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `each'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `config'
	from /home/suse/agama/service/lib/agama/config.rb:43:in `load'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:70:in `config'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:82:in `build_service'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:50:in `run'
	from bin/agamactl:65:in `start_service'
	from bin/agamactl:107:in `<top (required)>'
```

It only happens when running Agama under a root session. Funny enough,
it did not happen when using `sudo`.


## Solution

Use `YAML.safe_l... (continued)

Run Details

1413 of 2163 branches covered (0.0%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

4 existing lines in 2 files now uncovered.

15970 of 21094 relevant lines covered (75.71%)

21.23 hits per line