safe-global / safe-client-gateway / 7249845280

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add notifications for recovery proposals (#922)

This adds base notifications logic for alerts of owner management transactions, be them "direct" with the Safe or via in a batched `multiSend` call:

- `addOwnerWithThreshold`
- `removeOwner`
- `swapOwner`
- `changeThreshold`

If an alert is received containing one of the above, it is forwarded onto the email provider with what the new Safe state would be after the proposed recovery attempt is executed.

* feat: add notifications for recovery proposals

* feat: add notifications for recovery proposals

* fix: add test for `addOwnerWithThreshold`

* refactor: address review + add test comment

* chore: add todo tests

* fix: add test coverage

* refactor: only call `_notifyUnknownTransaction` once

* Revert "refactor: only call `_notifyUnknownTransaction` once"

This reverts commit 110716087.

* fix: retrieve email addresses first

* fix: change status code in tests

* fix: move `return`

Run Details

1427 of 1702 branches covered (0.0%)

Branch coverage included in aggregate %.

28 of 30 new or added lines in 1 file covered. (93.33%)

1 existing line in 1 file now uncovered.

5336 of 5790 relevant lines covered (92.16%)

149.25 hits per line