basilisp-lang / basilisp / 7216198757

99%

push

github

Fix issue with `readerwritelock` usage in basilisp (#722) (#731)

Hi,

could you please review patch to fix what it seems to be a potential
issue with how readwrite locks are used in basilisp. It addresses #722.

This was discovered while testing of the upcoming nrepl-server described
in #723. The nrepl-server tests which are using threads were failing due
to trying to release an rlock which has been already released, and is
fixed as described in #722 by using `with self._lock.gen_rlock()`
instead of a single instance of `with self._rlock()`. The error was
```
    File "/home/runner/work/basilisp/basilisp/.tox/py39/lib/python3.9/site-packages/basilisp/lang/runtime.py", line 706, in find
    return v
   File "/home/runner/work/basilisp/basilisp/.tox/py39/lib/python3.9/site-packages/readerwriterlock/rwlock.py", line 49, in __exit__
    self.release()
   File "/home/runner/work/basilisp/basilisp/.tox/py39/lib/python3.9/site-packages/readerwriterlock/rwlock.py", line 344, in release
    if not self.v_locked: raise RELEASE_ERR_CLS(RELEASE_ERR_MSG)
 RuntimeError: release unlocked lock
```

Thanks

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1644 of 1646 branches covered (0.0%)

Branch coverage included in aggregate %.

35 of 35 new or added lines in 3 files covered. (100.0%)

7723 of 7804 relevant lines covered (98.96%)

0.99 hits per line