safe-global / safe-client-gateway / 7211760186

89%

push

github

Remove Transaction Service + Exchange Rates API token prices retrieval (#898)

Configuration changes:
- `FF_PRICES_PROVIDER_CHAIN_IDS` has been removed, as it is not applicable right now. Price retrieval is being done via CoinGecko for all the chains.

Domain changes:
- `DomainModule` was updated: some unused classes were removed from the module initialization.
- `BalancesRepository` was updated: now the class only implements one way to retrieve balances.
- Validators, interfaces, and test utility classes for the old `Balance` items, and for the Exchange API specific classes were removed.
- `src/domain/balances/entities/schemas/balance.schema.ts` was partially removed.

Datasource changes: 
- `/datasources/exchange-api` folder and its contents are deleted from the project, as its classes are not used anymore.
- `CacheRouter.EXCHANGE_FIAT_CODES_KEY`, `CacheRouter.EXCHANGE_RATES_KEY` and related functions.
- `CacheRouter.getBalanceCacheDir` was removed.
- `TransactionApi.clearLocalBalances` and `TransactionApi.getBalances` were refactored/removed.

Routes changes:
- `BalancesService` was updated: now the class only implements one way to retrieve balances.
- `BalancesController` tests classes were updated to remove the testing of the removed classes.

Out of scope:
- During the transition to the new way of retrieving prices (via a prices provider), `SimpleBalance` and some related classes/functions were introduced, to make some distinctions between strategies. It makes sense now to rename `SimpleBalance` to `Balance` again, but this will be done in a separate PR for the sake of clarity.

1413 of 1701 branches covered (0.0%)

Branch coverage included in aggregate %.

10 of 12 new or added lines in 4 files covered. (83.33%)

5337 of 5810 relevant lines covered (91.86%)

151.58 hits per line