Stellarium / stellarium / 7156860731

11%

Build Type

push

github

Committed by alex-w

Commit Message

Fix crash in StelTexture destructor on exit

On deletion of StelApp StelTextureMgr is deleted, after which some
instances of StelTexture are deleted. But StelTexture destructor logs
VRAM usage via StelTextureMgr, accessing a no longer existing object.

This commit turns the nonstatic raw pointer to texture manager into a
static weak pointer (QPointer), so that it was possible to check whether
texture manager still exists before trying to access it. Making it
static is supposed to prevent useless copying of this smart pointer
while the texture manager is effectively a singleton.

Fixes #3427

Run Details

0 of 10 new or added lines in 2 files covered. (0.0%)

3 existing lines in 2 files now uncovered.

14843 of 128385 relevant lines covered (11.56%)

29405.1 hits per line