jlfwong / speedscope / 7136730558

44%

master: 47%

push

github

Add bounds checking for sampleTypeIndex (#449)

Wow this was surprising. As reported in #448, the `simple.speedscope.json` file failed import. This was surprising to me because there's a test that covers that file to ensure it imports correctly.

The file provided in #448, however, is from a version of speedscope from 5 years ago before the file had been pretty printed. It turns out that when this *particular* file is not pretty-printed, it's a schematically valid pprof profile.

The fix is to do some bounds checks and return null. After the change, the file imports as you'd expect after realizing its not actually a valid pprof profile.

Fixes #448

1156 of 2771 branches covered (0.0%)

Branch coverage included in aggregate %.

4 of 5 new or added lines in 1 file covered. (80.0%)

2620 of 6002 relevant lines covered (43.65%)

6357.7 hits per line