NaturalNode / natural / 7130642836

87%

push

github

Update TypeScript declarations (#679)

* [WIP] Update TS declarations

Importing natural in typescript projects using the provided type
declarations won't work until the declaration files themselves can be
compiled without errors. These are the minimum changes needed to resolve
the remaining errors.

* SentenceAnalyzer: Update TS declarations

- TaggedWord: Add property pp and remove index because there don't appear
  to be any other keys.
- TaggedSentence: punct() method is called in type() without checking for
  existence first, so should not be optional.
- SenType: Define the only possible strings that can be assigned to
  .sentType as an enum.
- SentenceAnalyzer: subjectToString() and predicateToString() can only
  return strings because ['a', null, 'b'].join('') === 'ab'.

* [WIP] BrillPosTagger: Update TS declarations

- Add RuleTemplate and index RuleTemplates
- Use Sentence type for several sentence parameters
- Replace non-existent function() method in Predicate with property meta
- Add properties and methods to TransformationRule, RuleSet, Corpus
- TODO: BrillPOSTagger, BrillPOSTester, BrillPOSTrainer

* BrillPosTagger: Update TS declarations

- Add remaining methods to BrillPOSTagger
- Add classes for BrillPOSTester, BrillPOSTrainer

* Address linting errors

* [WIP] Update classifier TS declarations

- Add apparatus classifier declarations since that library doesn't
  output types
- Make BayesClassifier and LogisticRegressionClassifier extend a common
  ClassifierBase class
- Update some any types
- Update classifiers test with updated types

* [WIP] Update error types in classifier callbacks

- null value expected when no error

* [WIP] Update classifier TS declarations

Some of these changes need to be revisited for accuracy.

- Add constructors to classes that extend a base class
- Remove unnecessary 'export' from 'declare class' (still confused about
  what needs an explicit export in... (continued)

2522 of 3309 branches covered (0.0%)

Branch coverage included in aggregate %.

9403 of 10509 relevant lines covered (89.48%)

67936.44 hits per line