tarantool / luajit / 7118840768

70%

tarantool/master: 93%

Build Type

push

github

Committed by igormunkin

Commit Message

Fix FOLD rule for BUFHDR append.

Reported by XmiliaH.

(cherry-picked from commit bc1bdbf62)

`bufput_append()` may fold `BUFHDR RESET` + `BUFPUT` IRs to `BUFHDR
APPEND` even if the right operand (`BUFSTR`) is the PHI. If it's not the
last IR in the `BUFSTR` chain, this may lead to an incorrect resulting
value in the buffer, which contains a longer string since `APPEND` is
used instead of `RESET`.

This patch adds the corresponding check inside the fold rule.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#9145

Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>
(cherry picked from commit e895818a7)

Run Details

5354 of 5969 branches covered (0.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

16 existing lines in 4 files now uncovered.

20518 of 23265 relevant lines covered (88.19%)

699013.82 hits per line