MITLibraries / transmogrifier / 7115514238

99%

push

github

Gdt 83 jsontransformer (#107)

* Transformer and XmlTransformer refactor

* Retype Transformer class as ABC
* Reorder Transformer class methods for more logical flow
* Replace abstractmethod return statements with pass
* Shift get_valid_title method to Transformer base class final method
* Remove outdated Transformer class test
* Update get_main_titles method in datacite, dspace_dim, dspace_mets, and oaidc transforms to return str values

* Create JsonTransformer class

Why these changes are being introduced:
* A generic JSON format class is needed as a base class for JSON metadata formats such as aardvark

How this addresses that need:
* Create JsonTransformer class
* Rename write_timdex_records_to_json > write_timdex_records_to_json_file
* Shift write_deleted_records_to_file from helpers module to Transformer method and rename to write_deleted_records_to_txt_file
* Shift CLI codeblock to Transformer.write_output_files method
* Add corresponding unit tests for write_output_files method

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/GDT-83

* Updates based on discussion in PR #107

* Rename _write_output_files > transform_and_write_output_files
* Rename write_timdex_records_to_json_file > _write_timdex_records_to_json_file
* Rename write_deleted_records_to_txt_file > _write_deleted_records_to_txt_file
* Add docstrings
* Add abstractmethod decorator to get_main_titles

94 of 129 new or added lines in 6 files covered. (72.87%)

1179 of 1218 relevant lines covered (96.8%)

0.97 hits per line