veeso / ssh2-config / 7102648735

90%

push

github

fix: correctly apply configuration precedence in reverse parsing order (#12)

* fix: correctly apply configuration precedence in reverse parsing order

This change fixes #11:

Previously, the order of precedence applied to
parsed configuration was incorrect.

Configuration was parsed, then sorted in
alphabetical order.

Algorithms (ciphers, key
exchange algorithms, MACs, etc.) were incorrectly
applied during parsing.

The correct precedence order follows
https://linux.die.net/man/5/ssh_config: the
configuration is read from top to bottom,
precedence is applied from bottom (lowest)
to the top (highest precedence).

Options preceding the first `Host` block are
considered implicit command line options, in
line with OpenSSH's own implementation.

This patch includes the following changes:

- Remove the alphabetic ordering of host sections.

- Merge matching host sections in reverse order.

- More efficiently merge host sections with
  vastly reduced `clone`s. (`clone` on demand.)

- Resolve algorithms not during the parsing,
  but during the resolving stage.

- More efficiently resolve algorithms, without
  source list mutation.

- Adjust existing unit tests to test the corrected
  precedence algorithm.

* feat: improve error-tests by matching on error enum variant

This change improves error-tests by replacing
`Result::is_err` with a match against the error
enum.

Previously, only the existence of an error result
was checked.

With the first additional commit,
the kind of error is checked as well.

* style: return `Result` from success tests, using `?` (Rust 2018 idiom)

This change improves success-tests by applying
the Rust 2018 idiom of returning `Result`
from tests.

This way, `Result::unwrap` and `Result::is_ok`
can be replaced by `?`.

Any error occurring in a success-test
is propagated to the test runner.

Some tests previously called `.ok().unwrap()` on
`Result`s, effectively firs... (continued)

284 of 300 new or added lines in 2 files covered. (94.67%)

1193 of 1224 relevant lines covered (97.47%)

13.47 hits per line