tarantool / tarantool / 7097826536

88%

Build Type

push

github

Committed by locker

Commit Message

box: fix the comparison in the functions cache

Before this patch it could happen that deletion of a function from
the function cache didn't delete it from the funcs_by_name map. The
reason is that the check if the function exists in the map performs
the comparison of the search result with the `end` backet ID of the
wrong hash table.

The situation in which this could happen is the following:
1. Insertion of a new function into the cache triggers resize of the
   funcs_by_value map, but the size of the funcs map remains the same.
2. Then user deletes a function. This removes the function from the
   funcs map. Then we check if the function exists in the
   funcs_by_value map. The function exists there, but it so happens
   that it's bucket ID equals to the funcs map bucket count, so the
   incorrect check if the function exists in the funcs_by_value map
   states that the function does not exist there, so it's not dropped
   from the map.
3. Now we have the following result: the function is referenced in
   the funcs_by_value map, but not in funcs map. This triggers the
   assertion failure on any attempt to insert a new function with
   the same name.

Closes #9426

NO_DOC=bugfix

Run Details

66048 of 118172 branches covered (0.0%)

1 of 1 new or added line in 1 file covered. (100.0%)

42 existing lines in 14 files now uncovered.

98207 of 113131 relevant lines covered (86.81%)

2649228.32 hits per line