bcollazo / catanatron / 7066460947

94%

push

github

Implements minor readability changes. (#260)

* nit: Rename bfs method as dfs due to LIFO ordering.

* Skip unnecessary None check.

* Simplify connected components logic in build_road.

* Simplify expandable_nodes computation.

* Remove an unnecessary temp variable in buildable_edges.

* Prefer .append on list type for performance.

* Simplify longest_acyclic_path logic for readability.

* Adds friendly road helper method.

* Return early in road_building_possibilities if possible.

* Return early in 'city_possibilities' if possible.

* Simplify logic in 'get_player_port_resources'.

38 of 39 new or added lines in 2 files covered. (97.44%)

1370 of 1429 relevant lines covered (95.87%)

0.96 hits per line